Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: add a test for ENV name (without =value) #33557

Merged
merged 1 commit into from
Jun 7, 2017
Merged

builder: add a test for ENV name (without =value) #33557

merged 1 commit into from
Jun 7, 2017

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda [email protected]

AkihiroSuda added a commit to AkihiroSuda/image-spec that referenced this pull request Jun 7, 2017
@AkihiroSuda
schema/config_test.go: add a test for an env var without =value
e1f9ddc 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 7, 2017
Merged
boaz0
boaz0 reviewed Jun 7, 2017
View reviewed changes
Copy link
Member

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless performance is really important here.
regexp are very expensive. Can we use strings.Contains and strings.Split instead?

@AkihiroSuda
Copy link
Member Author

@ripcurld0

I'm not using regexp here.
Probably you tried to review another PR opencontainers/image-spec#693?

thaJeztah
thaJeztah approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dnephin
dnephin approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester vdemeester merged commit d2c6e78 into moby:master Jun 7, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone Jun 7, 2017
AkihiroSuda added a commit to AkihiroSuda/image-spec that referenced this pull request Jun 13, 2017
@AkihiroSuda
schema/config_test.go: add a test for an env var without =value
bf681bb 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/image-spec that referenced this pull request Jun 23, 2017
@AkihiroSuda
schema/config_test.go: add a test for an env var without =value
1f0c993 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/image-spec that referenced this pull request Jun 23, 2017
@AkihiroSuda
schema/config_test.go: add a test for an env var without =value
5503959 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
dattgoswami9lk5g added a commit to dattgoswami9lk5g/bremlinr that referenced this pull request Jun 6, 2022
@dattgoswami9lk5g
schema/config_test.go: add a test for an env var without =value
e286581 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
7c00d pushed a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022
@wesnowm
schema/config_test.go: add a test for an env var without =value
6eb3957 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
7c00d added a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022
@7c00d
schema/config_test.go: add a test for an env var without =value
c39ac5c 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
laventuraw added a commit to laventuraw/Kihara-tony0 that referenced this pull request Jun 6, 2022
@laventuraw
schema/config_test.go: add a test for an env var without =value
f6aee1a 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
tomalopbsr0tt added a commit to tomalopbsr0tt/fabiojosej that referenced this pull request Oct 6, 2022
@tomalopbsr0tt
schema/config_test.go: add a test for an env var without =value
14fd0e6 
Related: moby/moby#33557

Signed-off-by: Akihiro Suda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boaz0 boaz0 boaz0 left review comments

@vdemeester vdemeester vdemeester approved these changes

@dnephin dnephin dnephin approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
17.06.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AkihiroSuda @vdemeester @dnephin @thaJeztah @boaz0 @GordonTheTurtle