Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add instructions field to InitializeResult #150

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: add instructions field to InitializeResult #150

merged 2 commits into from
Jan 13, 2025

Conversation

salman1993
Copy link
Contributor

@salman1993 salman1993 commented Jan 13, 2025 •
edited
Loading

This adds the instructions field.

Motivation and Context

The field is already in the MCP schema.

How Has This Been Tested?

Added a test

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@salman1993 salman1993 changed the title Add instructions field to InitializeResult feat: add instructions field to InitializeResult Jan 13, 2025
jspahrsummers
jspahrsummers requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this to ServerSession and FastMCP too, so servers have some way to provide this information? 🙏

jspahrsummers
jspahrsummers approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@jspahrsummers jspahrsummers merged commit 62a0af6 into modelcontextprotocol:main Jan 13, 2025
3 checks passed
@salman1993 salman1993 mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspahrsummers jspahrsummers jspahrsummers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salman1993 @jspahrsummers