Jerome/auth #260
Closed
Jerome/auth #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Dict[str, str] with a more precise TypedDict that captures the exact structure of OAuth error responses. Also updates imports to use Python 3.10 style type annotations.
… some signatures to validation functions
Resolves conflicts in OAuth implementation by: - Preserving modern typing with TypedDict for responses - Combining validation improvements for auth endpoints - Maintaining consistent error handling pattern - Integrating tests for all authorization flows
|
I ended up stepping on this a bunch with changes in #255; let's just close this. I ended up making most of the same changes in any event |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context