Update esbuild dependency of @web/dev-server-esbuild to fix bug with decorators
#2137
Conversation
🦋 Changeset detectedLatest commit: 3418e9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -52,7 +52,7 @@ | |||
| "dependencies": { | |||
| "@mdn/browser-compat-data": "^4.0.0", | |||
| "@web/dev-server-core": "^0.3.19", | |||
| "esbuild": "^0.12 || ^0.13 || ^0.14", | |||
| "esbuild": "^0.16 || ^0.17", | |||
There was a problem hiding this comment.
If there are no consumed APIs changing as part of this update, is there anything wrong with leaving the previous verions? 0.14.0 is at least a year old, so I'm not against dropping them, just wanted to get your thoughts. As a "breaking" change (patches before 1.0) it's not an issue either way.
There was a problem hiding this comment.
I suppose we could just leave the old ones. On the other hand; some old ones are broken, so we could prevent anyone from going down the same rabbit hole?
There was a problem hiding this comment.
Oh, yeah, if they are broken, let's use the breaking semantics of the change you've listed and exclude them. Great call!
Version
0.3.3of@web/dev-server-esbuilduses0.14.54of esbuild. This version has a bug that breaks experimental typescript decorators. Apparently this has been known quite a while and the workaround is to fix the version to0.2.16of dev-server-esbuild.This PR updates the esbuild dependency to 0.16 || 0.17.
All tests still pass.
fixes #1929