Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed numeric and mercury comparators, further refactoring #1222

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

andrzejj0
Copy link
Contributor

Third stage of the refactoring: removed the Numeric and Mercury comparators, some further refactoring in DefaultVersionsHelper.

Because we're removing comparators, a new version of rules.xsd is necessary and it's a breaking change.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should preserve old schema at site:
https://www.mojohaus.org/versions/versions-model/xsd/index.html
can be done at separate PR

@andrzejj0
Copy link
Contributor Author

@slawekjaranowski would that be ok?

Versions - XML schemas for ruleSet
==================================

- [rule-3.0.0.xsd](rule-3.0.0.xsd)
- [rule-2.1.0.xsd](https://www.mojohaus.org/versions-maven-plugin/xsd/rule-2.1.0.xsd)
- [rule-2.0.0.xsd](https://www.mojohaus.org/versions-maven-plugin/xsd/rule-2.0.0.xsd)

@slawekjaranowski
Copy link
Member

@slawekjaranowski would that be ok?

Versions - XML schemas for ruleSet
==================================

- [rule-3.0.0.xsd](rule-3.0.0.xsd)
- [rule-2.1.0.xsd](https://www.mojohaus.org/versions-maven-plugin/xsd/rule-2.1.0.xsd)
- [rule-2.0.0.xsd](https://www.mojohaus.org/versions-maven-plugin/xsd/rule-2.0.0.xsd)

try to generate site locally ...

we need an old link to works - https://www.mojohaus.org/versions/versions-model/xsd/rule-2.1.0.xsd
so we need a copy rule-2.1.0.xsd to versions-model/src/site/resources/xsd

@andrzejj0
Copy link
Contributor Author

I will do the proper site in another PR...

@andrzejj0 andrzejj0 merged commit e391402 into mojohaus:master Mar 9, 2025
26 checks passed
@github-actions github-actions bot added this to the 2.19.0 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants