Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): remove computed value from Catalogues.description #4779

Merged
merged 7 commits into from
Mar 1, 2025

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Feb 27, 2025

NOTE: first merge #4775, which will result in data model version 5.5

What are the main changes you did

  • removed computed value from Catalogues.description and edited demo data accordingly.

rdf api could not find computed value when it is computed from data in another table

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@BrendaHijmans BrendaHijmans self-assigned this Feb 27, 2025
@mswertz mswertz changed the title fix: remove computed value from Catalogues.description fix(catalogue): remove computed value from Catalogues.description Feb 28, 2025
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the change but can you please merge with the changes in the master?

@BrendaHijmans BrendaHijmans merged commit 666f9dc into master Mar 1, 2025
7 checks passed
@BrendaHijmans BrendaHijmans deleted the fix/Catalogues.description branch March 1, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants