Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated biobank card title #4794

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix: updated biobank card title #4794

merged 1 commit into from
Mar 4, 2025

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Mar 4, 2025 •
edited
Loading

What are the main changes you did

This PR closes molgenis/GCC#891

  • fix: changed biobank card title Organizations to Organisations

How to test

  • Navigate to the preview and go to the directory app
  • Note the new title

Note

I'm not entirely familiar with the directory app. If there are any issues as a result, please let me know.

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@davidruvolo51 davidruvolo51 self-assigned this Mar 4, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@davidruvolo51 davidruvolo51 marked this pull request as ready for review March 4, 2025 13:48
@mswertz mswertz requested a review from hslh March 4, 2025 14:07
mswertz
mswertz reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but as member of principle would be good if a data manager approves, e.g. @hslh

@davidruvolo51 davidruvolo51 merged commit 501e5b5 into master Mar 4, 2025
7 checks passed
@davidruvolo51 davidruvolo51 deleted the fix/dir-org-title branch March 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz left review comments

@hslh hslh hslh approved these changes

Assignees

@davidruvolo51 davidruvolo51

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidruvolo51 @mswertz @hslh