Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pytest logging? #139

Merged

Conversation

nathandunn
Copy link
Contributor

Doesn't look like pytest-logging is supported by 3.6. Should we use 3.5 only, or are we safe to remove it?

https://pypi.python.org/pypi/pytest-logging

Seems to work fine without it (do the behave tests rely on it?)

Otherwise with 3.6 we get an error. In that same vein, can we remove pytest as a requirement as well?

@nathandunn
Copy link
Contributor Author

This is the error I get from master:

Requirement already satisfied: pytest>=0.0 in ./venv/lib/python3.6/site-packages (from -r requirements.txt (line 16))
Collecting pytest-logging>=0.0 (from -r requirements.txt (line 17))
  Using cached pytest-logging-2015.11.4.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/yc/y5cfqt8j72165cyr68_bpw9r0000gn/T/pip-build-8uhty9xs/pytest-logging/setup.py", line 34, in <module>
        exec(rfh.read(), None, _LOCALS)  # pylint: disable=exec-used
      File "/usr/local/bin/../Cellar/python3/3.6.3/bin/../Frameworks/Python.framework/Versions/3.6/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 105: ordinal not in range(128)
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/yc/y5cfqt8j72165cyr68_bpw9r0000gn/T/pip-build-8uhty9xs/pytest-logging/

@nathandunn
Copy link
Contributor Author

pinging @cmungall / @kshefchek for review (or whomever else should take part)

@cmungall
Copy link
Member

TBH I don't recall why we had this there - pytest doesn't show logging messages? But seems effort is going into catchlog for now? See vmware-archive/pytest-logging#1

Don't have time to look in more detail, I say merge and then if we see issues with logging we can circle round again

@cmungall cmungall merged commit 308ea24 into monarch-initiative:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants