depends: boost: update to 1.69.0 [0.18] #9807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobtoht
changed the title
|
Do we know what change in Boost caused/fixed the issue? |
selsta
approved these changes
Feb 18, 2025
|
For visibility, as this was already discussed on irc. The commit that likely fixed the crash is: boostorg/asio@ad8cc21 |
iamamyth
approved these changes
Feb 19, 2025
MrCyjaneK
approved these changes
Feb 19, 2025
|
The presence of this bug in ASIO effectively raises the minimum Boost version to 1.69. Debian 10, which we support until at least 30 June 2025 ships Boost 1.67. When we drop support for Debian 10 the minimum becomes Boost 1.71 (Ubuntu 20.04). If it's easy to work around this bug on our side it would be nice to do so in a follow-up PR. Since this only affects one development environment and development builds can use the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a reported crash during sync on Windows that was introduced in #9800.
Context starting here: https://libera.monerologs.net/monero-dev/20250217#c497165
Includes #9457 backport (needed).