logging: Generalize terminal color detection #9808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume the terminal supports color codes if TERM ends with `-color` or `-256color`, rather than special-casing a handful of such terminals. Add tests for terminal color detection.
selsta
approved these changes
Feb 19, 2025
|
Changes LGTM. Thanks! |
laanwj
approved these changes
Feb 20, 2025
jeffro256
reviewed
Mar 3, 2025
| @@ -1211,6 +1211,8 @@ class OS : base::StaticClass { | |||
| /// @detail For android systems this is device name with its manufacturer and model seperated by hyphen | |||
| static std::string currentHost(void); | |||
| /// @brief Whether or not terminal supports colors | |||
| static bool termSupportsColor(std::string& term); | |||
| /// @brief Whether or not terminal supports colors | |||
There was a problem hiding this comment.
Perhaps you can clarify this to something along the lines of "the terminal attached to this environment", and change the previous to "a terminal with this name"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the terminal supports color codes if TERM ends with
-coloror-256color, rather than special-casing a handful of such terminals.Add tests for terminal color detection.