-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-47211-default-sort-order-setting #724
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ltran-mdb2, I left a few non-blocking suggestions for your consideration. LGTM!
source/settings/set-default-sort.txt
Outdated
Set Default Sort Order | ||
====================== | ||
|
||
.. default-domain:: mongodb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this directive is no longer functional. It was being removed in some tickets earlier this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
source/settings/set-default-sort.txt
Outdated
* - Sort Key | ||
- Description | ||
|
||
* - $natural: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be literals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djechlin-mongodb what do you think here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @djechlin-mongodb and we decided to leave these as non literals to match the Compass UI
|
||
.. list-table:: | ||
:header-rows: 1 | ||
:widths: 20 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: We don't use it widely, but with these sort of lexical reference tables the :stub-columns: 1
option sometimes helps with formatting for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good. Was wondering if you'd want to cover that these "defaults" aren't saved as part of the query when queries are saved, and furthermore that they're applied to already saved queries. I'm not sure if that level of detail is necessary.
I added a line about how these defaults are not saved as part of saved queries! |
DESCRIPTION
Adds new page on default sort order setting
STAGING
https://deploy-preview-724--docs-compass.netlify.app/settings/set-default-sort/#std-label-compass-sort-query-bar
https://deploy-preview-724--docs-compass.netlify.app/settings/settings-reference/#settings
https://deploy-preview-724--docs-compass.netlify.app/query/sort/
JIRA
https://jira.mongodb.org/browse/DOCSP-47211
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?