Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-47969 Compass 1.45.4 RN #725

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kennethdyer
Copy link
Collaborator

@kennethdyer kennethdyer commented Mar 3, 2025

DESCRIPTION

Release notes for 1.45.4.

STAGING

RN

JIRA

DOCSP-47969

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit bd8a7d7
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67cf29a476818f00075f4093
😎 Deploy Preview https://deploy-preview-725--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennethdyer kennethdyer force-pushed the DOCSP-47969-compass-rn branch from 70448f4 to cb55c34 Compare March 4, 2025 21:45
@@ -10,6 +10,29 @@ Release Notes
:depth: 1
:class: twocols

|compass| 1.45.4
----------------

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to External Reviewer: We need a release date.

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple comments! Thanks @kennethdyer.


Bug Fixes:

- Update maps from map tile API v2 to raster tile API v3 (:issue:`COMPASS-8981`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google seems to indicate that "Raster" should be capitalized.

Suggested change
- Update maps from map tile API v2 to raster tile API v3 (:issue:`COMPASS-8981`)
- Update maps from map tile API v2 to Raster Tile API v3 (:issue:`COMPASS-8981`)

https://www.here.com/docs/bundle/raster-tile-api-v3-api-reference/page/index.html

@@ -10,6 +10,29 @@ Release Notes
:depth: 1
:class: twocols

|compass| 1.45.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the snooty.toml release version as part of these changes.

Comment on lines +33 to +34
`Full Changelog available on Github
<https://github.com/mongodb-js/compass/compare/v1.45.3...v1.45.4>`__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to call out that this is currently showing as empty for me. It looks like the 1.45.4 branch hasn't been cut yet on GitHub, so I'm guessing once that happens this will work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants