-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44435-clarify-compass-buttons #728
base: master
Are you sure you want to change the base?
DOCSP-44435-clarify-compass-buttons #728
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update, @amalhotra-mdb! I've left two suggestions for your consideration.
Thanks!
Joe
@@ -49,8 +49,14 @@ | |||
|
|||
.. step:: Connect to your cluster. | |||
|
|||
Click :guilabel:`Save` or :guilabel:`Save & Connect` to navigate to the | |||
|compass-short| :ref:`Home Page <compass-home-screen>`. | |||
Click :guilabel:`Save`, :guilabel:`Connect`, or :guilabel:`Save & Connect` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
Consider rephrasing as: "To navigate to the |compass-short| :ref:`Home Page `, click :guilabel:`Save`, :guilabel:`Connect`, or :guilabel:`Save & Connect`."
|compass-short| :ref:`Home Page <compass-home-screen>`. | ||
Click :guilabel:`Save`, :guilabel:`Connect`, or :guilabel:`Save & Connect` | ||
to navigate to the |compass-short| :ref:`Home Page <compass-home-screen>`. | ||
The :guilabel:`Save` button saves your connection and closes the modal without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
Consider bulleting these out for improved scannability.
Thank you for these changes, @jmd-mongo ! Changes made, back to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes, @amalhotra-mdb! This one LGTM at this point.
Thanks,
Joe
Hi @lerouxb , could you take a look at this PR for an external review, when you get a chance? Thanks! |
DESCRIPTION
Clarify the difference bt the "save", "connect", and "save and connect" buttons when connecting to your cluster on Compass.
STAGING
https://deploy-preview-728--docs-compass.netlify.app/connect/#connect-to-your-cluster.
JIRA
https://jira.mongodb.org/browse/DOCSP-44435
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?