feat(NODE-3482)!: remove unref

etc/notes/CHANGES_5.0.0.md

@@ -0,0 +1,21 @@
+# Changes in v5
+
+## TOC
+
+- TODO
+
+## About
+
+The following is a detailed collection of the changes in the major v5 release of the mongodb package for Node.js.
+
+<!--
+1. a brief statement of what is breaking (brief as in "x will now return y instead of z", or "x is no longer supported, use y instead", etc
+2. a brief statement of why we are breaking it (bug, not useful, inconsistent behavior, better alternative, etc)
+3. if applicable, an example of suggested syntax change (can be included in (1) )
+-->
+
+## Changes
+
+### `.unref()` removed from `Db`
+
+The `.unref()` method was a no-op and has now been removed from the Db class.

src/db.ts

@@ -44,7 +44,6 @@ import {
   Callback,
   DEFAULT_PK_FACTORY,
   filterOptions,
-  getTopology,
   MongoDBNamespace,
   resolveOptions
 } from './utils';
@@ -738,14 +737,6 @@ export class Db {
     );
   }
 
-  /**
-   * Unref all sockets
-   * @deprecated This function is deprecated and will be removed in the next major version.
-   */
-  unref(): void {
-    getTopology(this).unref();
-  }
-
   /**
    * Create a new Change Stream, watching for new changes (insertions, updates,
    * replacements, deletions, and invalidations) in this database. Will ignore all

src/sdam/topology.ts

@@ -39,7 +39,6 @@ import type { Transaction } from '../transactions';
 import {
   Callback,
   ClientMetadata,
-  emitWarning,
   EventEmitterWithState,
   HostAddress,
   List,
@@ -711,13 +710,6 @@ export class Topology extends TypedEventEmitter<TopologyEvents> {
     return this.s.state === STATE_CLOSED;
   }
 
-  /**
-   * @deprecated This function is deprecated and will be removed in the next major version.
-   */
-  unref(): void {
-    emitWarning('`unref` is a noop and will be removed in the next major version');
-  }
-
   // NOTE: There are many places in code where we explicitly check the last hello
   //       to do feature support detection. This should be done any other way, but for
   //       now we will just return the first hello seen, which should suffice.

test/types/mongodb.test-d.ts

@@ -1,14 +1,13 @@
 import type { Document } from 'bson';
 import { expectDeprecated, expectError, expectNotDeprecated, expectType } from 'tsd';
 
-import { Db, WithId, WriteConcern, WriteConcernSettings } from '../../src';
+import type { WithId, WriteConcern, WriteConcernSettings } from '../../src';
 import * as MongoDBDriver from '../../src';
 import type { ChangeStreamDocument } from '../../src/change_stream';
 import { Collection } from '../../src/collection';
 import type { AggregationCursor } from '../../src/cursor/aggregation_cursor';
 import { FindCursor } from '../../src/cursor/find_cursor';
 import { MongoClient } from '../../src/mongo_client';
-import { Topology } from '../../src/sdam/topology';
 
 // We wish to keep these APIs but continue to ensure they are marked as deprecated.
 expectDeprecated(Collection.prototype.insert);
@@ -17,8 +16,6 @@ expectDeprecated(Collection.prototype.remove);
 expectDeprecated(Collection.prototype.count);
 expectDeprecated(Collection.prototype.mapReduce);
 expectDeprecated(FindCursor.prototype.count);
-expectDeprecated(Topology.prototype.unref);
-expectDeprecated(Db.prototype.unref);
 expectDeprecated(MongoDBDriver.ObjectID);
 expectNotDeprecated(MongoDBDriver.ObjectId);