Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation clean up #7

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Implementation clean up #7

wants to merge 2 commits into from

Conversation

moaahmad
Copy link

@moaahmad moaahmad commented Feb 7, 2025 •
edited
Loading

Summary:

Removes conversion from snake to camel case in Parameters and fixes…
69643b7 
… indentation to be 2 space to make it easier to merge back in upstream
@moaahmad moaahmad requested a review from a team as a code owner February 7, 2025 16:59
@moaahmad moaahmad requested review from Nunodnm and Josh-Bruce and removed request for a team and Nunodnm February 7, 2025 16:59
Josh-Bruce
Josh-Bruce approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Josh-Bruce Josh-Bruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense, thanks for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Bruce Josh-Bruce Josh-Bruce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moaahmad @Josh-Bruce