Fix weight limits in evm tracing runtimes #3210
Open
+144
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2400 KB (no changes) ✅ Moonriver runtime: 2412 KB (no changes) 🚨 Compared to latest release (runtime-3501)Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2400 KB (+460 KB compared to latest release) Moonriver runtime: 2412 KB (+472 KB compared to latest release) 🚨 |
Coverage Report@@ Coverage Diff @@
## master rq/fix-over-weight-when-tracing +/- ##
===================================================================
- Coverage 74.57% 74.56% -0.01%
Files 381 381
+ Lines 96700 96746 +46
===================================================================
+ Hits 72114 72130 +16
+ Misses 24586 24616 +30
|
This reverts commit a58f24a.
RomarQ
added
D3-trivial
stiiifff
reviewed
Mar 10, 2025
| EvmTracer::new().trace(|| Executive::apply_extrinsic(ext)); | ||
| EvmTracer::new().trace(|| { | ||
| if let Err(err) = Executive::apply_extrinsic(ext) { | ||
| log::debug!( |
There was a problem hiding this comment.
Is better to be just a debug log, some extinsics are expected to fail and we should not emit a warning for those cases.
I have added the debug log here, since we were ignoring the extrinsic result, and it is useful when debugging tracing problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The changes included in this pull request fix the weight limits used in evm tracing runtimes.
Runtimes with feature
evm-tracingenabled introduce additional (ref_time) overhead, since they have special logic to trace ethereum transactions (emitting events for each component:gasometer,runtime,evm) that is then used to fill all the information for (debug_traceTransaction,trace_filter, ...) rpc calls.Since the real ref_time in production runtimes is smaller, it means that we could reach the block weight limits when replaying a block in a evm-tracing runtime, and as result skip transactions traces. (Which was the case in moonbeam block 9770044)
What important points should reviewers know?
The fix consists in resetting the previously consumed weight before tracing each ethereum transaction, the fix only affects code under
evm-tracing, which is not included in any production runtime.