fix: MenuItem

moonshine-software · Sep 17, 2024 · 6e76945 · 6e76945
1 parent 6861a8d
commit 6e76945
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/MenuManager/src/MenuItem.php b/src/MenuManager/src/MenuItem.php
@@ -88,6 +88,9 @@ public function getFiller(): MenuFillerContract|Closure|string
         return $this->filler;
     }
 
+    /**
+     * @param Closure(string $path, string $host, static $ctx): bool  $when
+     */
     public function whenActive(Closure $when): static
     {
         $this->whenActive = $when;
@@ -131,7 +134,7 @@ public function isActive(): bool
     {
         $filler = $this->getFiller();
 
-        if ($filler instanceof MenuFillerContract) {
+        if ($filler instanceof MenuFillerContract && is_null($this->whenActive)) {
             return $filler->isActive();
         }