Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll autosuggestion list on mobile device #73

Closed
hannesj opened this issue Oct 14, 2015 · 3 comments
Closed

Can't scroll autosuggestion list on mobile device #73

hannesj opened this issue Oct 14, 2015 · 3 comments
Labels
bug

Comments

@hannesj
Copy link

hannesj commented Oct 14, 2015

This makes it possible to get faster feedback on mobile devices, but unfortunately it makes it impossible to scroll the list, as the onTouchStart fires also when starting to drag the list.
@hannesj hannesj changed the title Can's scroll autosuggestion list on mobile device Can't scroll autosuggestion list on mobile device Oct 14, 2015
@moroshko
Copy link
Owner

@hannesj onTouchStart was added because iOS devices didn't pick up onMouseDown at all, so tapping a suggestion on iPhone, for example, was causing the suggestions list to close without updating the input value. That's the history behind onTouchStart.

Any ideas how to fix this? Pull request is welcome!

0xjocke added a commit to 0xjocke/react-autosuggest that referenced this issue Oct 14, 2015
@0xjocke
ISSUE moroshko#73 Use touchTap event instead of touchstart.
58b6dbb
@0xjocke
Copy link
Contributor

0xjocke commented Oct 14, 2015

Hi!
I made a PR using react-tap-event-plugin. I added some thoughts as well. Please let me know what you think.
#75

moroshko added a commit that referenced this issue Oct 15, 2015
@moroshko
Merge pull request #75 from bachstatter/master
eb9c494 
ISSUE #73 Use touchTap event instead of touchstart.
@moroshko
Copy link
Owner

Thanks a lot! Version 2.1.1 is on npm now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moroshko @hannesj @0xjocke