Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next): record glean event for subscription cancellation #18370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(next): record glean event for subscription cancellation #18370

wants to merge 1 commit into from

Conversation

StaberindeZA
Copy link
Contributor

Because

  • Need to record a glean event when a customers subscription is cancelled

This pull request

  • Adds new metrics to glean subplat backend yaml
  • Records glean event on receiving Stripe webhook customer.subscripion.deleted

Issue that this pull request solves

Closes: #FXA-11139

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@StaberindeZA StaberindeZA requested a review from a team as a code owner February 13, 2025 18:21
@StaberindeZA StaberindeZA force-pushed the fxa-11139-glean-sub-deletion-event branch from bb90727 to e46d028 Compare February 13, 2025 18:22
@StaberindeZA StaberindeZA force-pushed the fxa-10089-next-webhooks branch 3 times, most recently from 6e66125 to f1d8a78 Compare February 14, 2025 16:18
@StaberindeZA StaberindeZA force-pushed the fxa-11139-glean-sub-deletion-event branch 2 times, most recently from 2bf6431 to 2af9c11 Compare February 19, 2025 15:26
xlisachan
xlisachan reviewed Feb 19, 2025
View reviewed changes
libs/payments/metrics/src/lib/glean/glean.manager.ts Outdated
@@ -126,10 +154,18 @@ export class PaymentsGleanManager {
priceId: '',
productId: '',
};
const emptySubscriptionCancellationData: SubscriptionCancellationData = {
voluntary: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the default be undefined?

xlisachan
xlisachan approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@xlisachan xlisachan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one q about voluntary.

LGTM, thanks Reino!

@StaberindeZA StaberindeZA force-pushed the fxa-10089-next-webhooks branch from f1d8a78 to b1877aa Compare February 20, 2025 19:54
Base automatically changed from fxa-10089-next-webhooks to main February 20, 2025 21:03
@StaberindeZA StaberindeZA force-pushed the fxa-11139-glean-sub-deletion-event branch 2 times, most recently from 2cb0ce3 to a4776f2 Compare February 21, 2025 21:06
@StaberindeZA
feat(next): record glean event for subscription cancellation
dd4a1e1 
Because:

- Need to record a glean event when a customers subscription is
  cancelled

This commit:

- Adds new metrics to glean subplat backend yaml
- Records glean event on receiving Stripe webhook
  customer.subscripion.deleted

Closes #FXA-11139
@StaberindeZA StaberindeZA force-pushed the fxa-11139-glean-sub-deletion-event branch from a4776f2 to dd4a1e1 Compare February 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaberindeZA @xlisachan