task(recovery-phone): Support twilio api key #18500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
FXA-11191
branch
4 times, most recently
from
8103881 to
37ea146
Compare
4 tasks
Because: - Integration tests would often fail locally. - Connection pool was getting exhausted - Connection pool was not getting terminated This Commit: - Exposes connection pool - Makes sure it's terminated when destroy is called on the Kysely db instance. - Adds a couple missing places where destroy wasn't called on the db instance.
Because: - We want to use twilio API keys - We don't want to use the twilio Auth Token This Commit: - Switches over to using api keys - Adds method for signing webhook urls, so we can validate webhook calls originated from us. - Adds ability to configure webhook url, keys for signing, and api keys. - Still supports authToken so it's backwards compatible - Creates custom mechanism for validating webhook calls, since the authToken is used by twilio to validate the signed payload. - Removes the twilio-signature auth strategy and moves validation inline due to hapi limitations accessing the payload in the authorization. - Adds lots of comments and some doc about how to manually test this with ngrok. - Updates functional tests so they work with api keys - Updates functional tests so they can work for smoke tests as well as ci pipeline tests. - Updates functional tests so that twilio client can be configured independently of auth servers twilio client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11191
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
See comments about readme for manual testing with ngrok. It'd be nice if the reviewer, validated this works for them as well.