fix(recovery-phone): Invalidate previous SMS codes #18508
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Mar 5, 2025
| @@ -175,7 +175,7 @@ export class RecoveryPhoneManager { | |||
| * @param uid | |||
| */ | |||
| async getAllUnconfirmed(uid: string): Promise<string[]> { | |||
| const redisKey = `${this.redisPrefix}:${uid}:*`; | |||
| const redisKey = `*:${this.redisPrefix}:${uid}:*`; | |||
There was a problem hiding this comment.
Not sure this will be efficient. Can we get this work by avoiding a '*' prefix?
There was a problem hiding this comment.
Looking at storeUnconfirmed, I don't understand why the * prefix is necessary.
Because: * Old codes were not cleared This commit: * Improve performance of key search by using scan instead of keys to process the keys in batches Closes #FXA-11111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11111
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.