Add Fenix locale handling (#665) #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested changes
May 2, 2024
There was a problem hiding this comment.
Thank you @piri-p for the PR! The change looks fine to me and also works as expected. But to not have to manually run the check for each PR/release would you mind to also add an automated test for all kind of scrapers at least for Fenix? For applications like Firefox and Thunderbird we should already have such tests but maybe you can cross-check as well.
Let me know if you have trouble in running the tests and I can help. Thanks again for working on this PR!
|
Thanks for your feedback @whimboo ! I have updated the code and add test cases. |
whimboo
requested changes
May 6, 2024
|
I have removed all except one test case for each scraper :) @whimboo |
whimboo
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #665 - Add Fenix locale handling @whimboo