Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong argument order for (all ?) super(*,*) calls #18

Closed
mpounsett opened this issue Dec 6, 2018 · 2 comments
Closed

Wrong argument order for (all ?) super(*,*) calls #18

mpounsett opened this issue Dec 6, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@mpounsett
Copy link
Owner

Original report by Vincent Danjean (Bitbucket: vdanjean, GitHub: vdanjean).


Hi,
I tried to subclass the Range class in one of my project. I'm using the official Debian package (ie upstream version 1.2.4).
I see that new in the Range class is calling super(cls, Range) instead of super(Range, cls)

I checkout the last sources and see that, in the repo, the Range object do not have the new method anymore. However, a quick look show me that the remaining call to super(,) have their parameters reverted. With basic usage, it is not a problem (as both parameters refer to the same type), but it leads to problem when subclassing AND overriding the method.

Regards,
Vincent

@mpounsett
Copy link
Owner Author

Original comment by Christian Kauhaus (Bitbucket: ckauhaus, GitHub: ckauhaus).


Thank you for the bug report. I'll have a look at it during the next days.

@mpounsett mpounsett added major library bug Something isn't working needs review Needs developer review before assigning a milestone and removed library major labels Nov 7, 2019
@mpounsett
Copy link
Owner Author

I don't think Christian ever had a chance to look at this before I took over the project. I've done some digging and found a bunch of places where arguments are swapped. I think I've identified them all.

@mpounsett mpounsett removed the needs review Needs developer review before assigning a milestone label Feb 6, 2022
@mpounsett mpounsett added this to the 1.3.3 milestone Feb 6, 2022
mpounsett added a commit that referenced this issue Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant