Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this ugly PR accomplishes...
Rename hipercow.windows to hipercow.dide in various places.
In main hipercow, rename windows.R to dide.R, and various function renaming.
In hipercow.dide, various functions starting with
windows_
were in driver-windows.R, but were shared between windows and linux. Renamed these todide_
and moved them to driver-base.R.Push through tests and vignettes.
NB - github is showing quite a confusing diff here - particularly:-
Also, tests/testthat/test-windows.R has been renamed to test-dide.R with some changes; github diff has not picked that up very well, so test-dide.R is appearing as a new file.
To-Do - regenerate vignettes from vignettes_src
Lots more doc work to do, especially around the "Windows" focussed one - but for another PR.