Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipercow.windows -> hipercow.dide #169

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

hipercow.windows -> hipercow.dide #169

wants to merge 4 commits into from

Conversation

weshinsley
Copy link
Contributor

@weshinsley weshinsley commented Mar 10, 2025

So this ugly PR accomplishes...

  1. Rename hipercow.windows to hipercow.dide in various places.

  2. In main hipercow, rename windows.R to dide.R, and various function renaming.

  3. In hipercow.dide, various functions starting with windows_ were in driver-windows.R, but were shared between windows and linux. Renamed these to dide_ and moved them to driver-base.R.

  4. Push through tests and vignettes.

NB - github is showing quite a confusing diff here - particularly:-

  • it thinks windows/driver-windows.R has been morphed into dide/driver-base.R - I can sort of understand why, as much of driver-windows.R was common, and was moved into driver-base.R , but it looks more messy than it is, and a manual diff may be clearer

Also, tests/testthat/test-windows.R has been renamed to test-dide.R with some changes; github diff has not picked that up very well, so test-dide.R is appearing as a new file.

To-Do - regenerate vignettes from vignettes_src

Lots more doc work to do, especially around the "Windows" focussed one - but for another PR.

@weshinsley weshinsley changed the title Terrifying commit hipercow.windows -> hipercow.dide Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (892009d) to head (e40375c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         2481      2481           
=========================================
  Hits          2481      2481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant