Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default configuration #15

Merged
merged 8 commits into from
Apr 24, 2020
Merged

Added default configuration #15

merged 8 commits into from
Apr 24, 2020

Conversation

mshrwtnb
Copy link
Owner

@mshrwtnb mshrwtnb commented Apr 24, 2020

This PR enables ALRT to use defaultConfiguration.
By setting defaultConfiguration, ALRT can ...

  1. Show an UIAlertController with user-defined tint color
  2. Show OK and Cancel buttons with user-defined titles

See https://github.com/mshrwtnb/ALRT/pull/15/files#diff-f748f6c5192632893abcb48efd218a3fR105-R140 to understand how to use defaultConfiguration and its expected behavior.

@mshrwtnb mshrwtnb self-assigned this Apr 24, 2020
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #15 into master will decrease coverage by 0.16%.
The diff coverage is 75.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   71.59%   71.42%   -0.17%     
==========================================
  Files           1        1              
  Lines          88       77      -11     
==========================================
- Hits           63       55       -8     
+ Misses         25       22       -3     
Impacted Files Coverage Δ
ALRT/ALRT.swift 71.42% <75.60%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdf042...38aaf37. Read the comment docs.

@mshrwtnb mshrwtnb merged commit 6ea2c67 into master Apr 24, 2020
@mshrwtnb mshrwtnb deleted the defaultConfiguration branch April 24, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant