Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: fix C modules installation/removal on CLANG64 and CLANGARM64 #23494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luau-project
Copy link
Contributor

Description

Fixes #23493
Fixes the upstream issue luarocks/luarocks#1428 for MSYS2, because even though it was supposed to be fixed at luarocks/luarocks#1616, it still happens on MSYS2 even after a LuaRocks upgrade.

Changes:

Note

I'll try to upstream these changes.

@luau-project
Copy link
Contributor Author

Update

Conclusion

Since both changes proposed here were merged upstream on top of LuaRocks 3.11.1, I think it would be cleaner to update LuaRocks towards 3.11.1 rather than 3.9.2 as I am doing here.

Question: What would be the correct way to proceed:

  1. Update LuaRocks 3.9.2 as it is?
  2. Update to LuaRocks 3.11.1 referencing the merges?
  3. Something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant