[new-packages] tree-sitter-c, tree-sitter-lua, tree-sitter-markdown, tree-sitter-query, tree-sitter-vim, tree-sitter-vimdoc #23499
+275
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Biswa96 neovim maintainer |
ognevny
reviewed
Feb 25, 2025
mingw-w64-neovim/PKGBUILD
Outdated
| @@ -93,4 +99,7 @@ package() { | |||
| DESTDIR="${pkgdir}" "${MINGW_PREFIX}"/bin/cmake.exe --install . | |||
|
|
|||
| install -Dm644 "${srcdir}/${_realname}-${pkgver}/LICENSE.txt" "${pkgdir}${MINGW_PREFIX}/share/licenses/${_realname}/LICENSE.txt" | |||
|
|
|||
| # Symlink tree-sitter grammars directory to nvim runtime path | |||
| ln -s "${MINGW_PREFIX}/lib/tree_sitter" "${pkgdir}${MINGW_PREFIX}/share/nvim/runtime/parser" | |||
There was a problem hiding this comment.
symlink won't work as you expect: https://www.msys2.org/docs/symlinks/
There was a problem hiding this comment.
You are correct; this cannot be the best solution as it inadvertently bundles the tree-sitter-* so files with neovim. I changed it so that the tree-sitter-* packages add to the neovim runtime path directly in their respective packages.
Remove lib from dependency names Fix so that clang can build Remove symlink; add to neovim runtime path instead Accidentally added package remove unneccasary make makedepend
ognevny
force-pushed
the
add-neovim-dependencies
branch
from
42f989e to
95e90e5
Compare
|
I believe you've done a good work on testing it I rebased some commits for a cleaner history. removed thanks |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are dependencies for newer versions of neovim. Currently neovim gives an error when opening
*.lua,*.c,*.md,*.vim, and when opening vim documentation since the program lacks these dependencies.Proof they are now dependencies here and here.