refactor: remove .Empty #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefer the simpler `len` check for Multiaddr and `== nil` for `*Component`.
sukunrt
approved these changes
Feb 22, 2025
MarcoPolo
added a commit
that referenced
this pull request
Feb 24, 2025
prefer the simpler `len` check for Multiaddr and `== nil` for `*Component`.
MarcoPolo
added a commit
that referenced
this pull request
Feb 24, 2025
…ent (#272) * Backwards compatible Encapsulate/Decapsulate/Join * remove EncapsulateC * feat: Add Multiaddr.AppendComponent * remove .Empty (#274) prefer the simpler `len` check for Multiaddr and `== nil` for `*Component`. * export AsMultiaddrer interface * rename AsMultiaddr to Multiaddr Export Multiaddrer interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefer the simpler
lencheck for Multiaddr and== nilfor*Component.This helps with backward compatibility with v0.14. For example, this change: https://github.com/filecoin-project/lotus/pull/12912/files#diff-dd6a7924e7591cf2ed56af793a333f61f17a4a472d0ea542334ff841f5918c0dL63 would no longer be required.