Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MD4,MD5; add warning about obsolete hash functions #76

Merged
merged 5 commits into from
Sep 4, 2017

Conversation

celeduc
Copy link
Contributor

@celeduc celeduc commented Mar 4, 2017

Resolves #71 by adding MD4 and MD5 to the list of supported hash functions.

Adds a note to the README cautioning about their use.

@celeduc
Copy link
Contributor Author

celeduc commented Mar 5, 2017

@jbenet could you please look this over? I'm actually in need of this functionality.

@ghost
Copy link

ghost commented Mar 5, 2017

I think these codes look good to me, what do you think @diasdavid @whyrusleeping

@celeduc could you also add these to the csv in multicodec? That one is the canonical table and multihash is just a subset. I dislike the duplication too, PRs very welcome :)

@daviddias
Copy link
Member

Seems that there is no collision with https://github.com/multiformats/multicodec/blob/master/table.csv, as @lgierth said, we prefer to have the codecs first merged at the multicodec table then on the specs that dependent on it, so once we have that, we are golden to merge all of them PRs :)

@celeduc
Copy link
Contributor Author

celeduc commented Mar 6, 2017

I submitted PR #41 to multicodec, where it's held with a comment by @Kubuxu

@celeduc
Copy link
Contributor Author

celeduc commented Sep 4, 2017

Ready for merge!

@daviddias daviddias merged commit 85080b6 into multiformats:master Sep 4, 2017
@daviddias
Copy link
Member

thank you @celeduc :)

@celeduc celeduc deleted the mds branch September 4, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants