Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand,interp: trim whitespace in atoi #935

Merged
merged 1 commit into from
Oct 26, 2022
Merged

expand,interp: trim whitespace in atoi #935

merged 1 commit into from
Oct 26, 2022

Conversation

mvdan
Copy link
Owner

@mvdan mvdan commented Oct 23, 2022

(see commit message)

Fixes #928.

@mvdan mvdan merged commit 279b806 into master Oct 26, 2022
theclapp
theclapp reviewed Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@theclapp theclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late, but LGTM.

@mvdan mvdan deleted the atoi-space branch November 22, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theclapp theclapp theclapp left review comments

@riacataquian riacataquian riacataquian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interp: some binary tests should use space trim before atoi
3 participants
@mvdan @theclapp @riacataquian