-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement lora params & methods #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/LlamaContext.cpp: Language not supported
- src/LlamaContext.h: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/LlamaContext.cpp: Language not supported
- src/LlamaContext.h: Language not supported
Comments suppressed due to low confidence (4)
lib/binding.ts:42
- [nitpick] The parameter name 'lora_list' is ambiguous. It should be renamed to 'loraAdapters' for better clarity.
lora_list?: { path: string; scaled: number }[];
lib/binding.ts:119
- The method 'applyLoraAdapters' should have corresponding tests to ensure its functionality.
applyLoraAdapters(lora_adapters: { path: string; scaled: number }[]): void;
lib/binding.ts:120
- The method 'removeLoraAdapters' should have corresponding tests to ensure its functionality.
removeLoraAdapters(): void;
lib/binding.ts:121
- The method 'getLoadedLoraAdapters' should have corresponding tests to ensure its functionality.
getLoadedLoraAdapters(): Promise<{ count: number; lora_adapters: { path: string; scaled: number }[] }>;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/LlamaContext.cpp: Language not supported
- src/LlamaContext.h: Language not supported
Comments suppressed due to low confidence (1)
lib/binding.ts:119
- [nitpick] The method name 'getLoadedLoraAdapters' is inconsistent with other method names. It should be renamed to 'getLoadedAdapters' for clarity and consistency.
getLoadedLoraAdapters(): { path: string; scaled: number }[]
lora
/lora_scaled
/lora_list
applyLoraAdapters
/removeLoraAdapters
/getLoadedAdapters