cmd/egrunner: simplify checking for shell asserts #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
commented
Nov 10, 2018
go.sum
Outdated
| @@ -26,7 +26,6 @@ github.com/kr/pty v1.1.1 h1:VkoXIwSboBpnk99O/KFauAEILuNHv5DVFKZMBN/gUgw= | |||
| github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= | |||
| github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE= | |||
| github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= | |||
| github.com/myitcv/gopherjs v0.0.0-20181106113007-59ba804b0d30 h1:ZGxBik0evtvAinQthsLvCU0nQyYcK1tv+d0KoyIitGo= | |||
There was a problem hiding this comment.
go mod tidy removed this, and I have no idea why. I'm on go version devel +fe2c588b1c Sat Nov 10 13:39:01 2018 +0000 linux/amd64.
There was a problem hiding this comment.
go mod tidy is being too aggressive (golang/go#27868 (comment))
The "fix" is to run go list all afterwards, e.g. https://github.com/myitcv/gobin/blob/696e4dd2ca6c4442d5eb3dc45748de11fd413b92/.travis.yml#L21
mvdan.cc/sh version 2.6 adds syntax.Word.Lit, which makes it trivial to check if a word is simply an unquoted literal. Update the dependency and remove the now unnecessary reflection code.
|
Looks great, thanks, @mvdan. I've force-pushed the "fix" to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvdan.cc/sh version 2.6 adds syntax.Word.Lit, which makes it trivial to
check if a word is simply an unquoted literal. Update the dependency and
remove the now unnecessary reflection code.