Add proxy setting retrieving for chat open ai node, to fix https://github.com/n8n-io/n8n/issues/10901 #13678
+172
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add proxy setting retrieving for chat open ai node, to fix issue 10901
Related Linear tickets, Github issues, and Community forum posts
I investigated through the source code, confirm that open ai node does NOT respect any http_proxy setting, when it call langchain's openai client.
The issue happens, because HTTP "fetch" api does not respect http_proxy. It is required to set the Proxy Agent explicitly. Other HTTP nodes(i.e. Google Calendar) works because they are using AXIOS for HTTP invoking instead.
The original issue is posed @ issue 10901
I have verified it via ProxyMan. the https traffic of open ai can be seen in the screenshot:
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)