Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy setting retrieving for chat open ai node, to fix https://github.com/n8n-io/n8n/issues/10901 #13678

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasonliusz
Copy link

@jasonliusz jasonliusz commented Mar 4, 2025

Summary

Add proxy setting retrieving for chat open ai node, to fix issue 10901

Related Linear tickets, Github issues, and Community forum posts

I investigated through the source code, confirm that open ai node does NOT respect any http_proxy setting, when it call langchain's openai client.
The issue happens, because HTTP "fetch" api does not respect http_proxy. It is required to set the Proxy Agent explicitly. Other HTTP nodes(i.e. Google Calendar) works because they are using AXIOS for HTTP invoking instead.

The original issue is posed @ issue 10901

I have verified it via ProxyMan. the https traffic of open ai can be seen in the screenshot:

55BE1DA8-9A59-4BA1-BA04-185C2871C9E3

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jason seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Mar 4, 2025
@Joffcom
Copy link
Member

Joffcom commented Mar 4, 2025

Hey @jasonliusz,

Thanks for the PR, We have created "GHC-1048" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langchain nodes not respecting HTTP proxy settings
3 participants