Implement setpin development #128 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
|
Triggered a Cirrus rebuild.... |
|
The ShellCheck error is strange, hopefully that's just a fluke. |
|
ACK 7547bbf, please squash and then I'll merge. |
set pin getting the old or current pin and a new pin then check for error and return nil if no error fixed typo : session error variable from sessionErr to conventional error name "err" remove todo and comment in the head of function implemented setpin function
yorubad-dev
force-pushed
the
implement-setpin-development
branch
from
7547bbf to
a151e59
Compare
|
The Firefox Nightly fails look like a fluke. |
|
ACK a151e59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.