doc: Modified README.md and ko/README.md #1027
Conversation
README.md
Outdated
| @@ -88,7 +88,7 @@ For recording, the executable needs to be compiled with the `-pg` | |||
| (or `-finstrument-functions`) option which generates profiling code | |||
| (calling mcount or __cyg_profile_func_enter/exit) for each function. | |||
|
|
|||
| Note that, there's an experimental support for dynamic tracing on x86_64 | |||
| Note that, there's an experimental support for dynamic tracing on x86_64 and AArch64 (ARM64) | |||
There was a problem hiding this comment.
Please do not go over 80 characters in a single line.
|
Please change the commit message from AArch53 to AArch64. |
|
amend commit message from AArch53 to AArch64 |
My mistake..! I amended the commit message |
README.md
Outdated
| (although it still needs recompilation of your program). Please see | ||
| [doc/uftrace-record.md](doc/uftrace-record.md) file. | ||
| Note that, there's an experimental support for dynamic tracing on | ||
| x86_64 and AArch64 (ARM64) which doesn't require such (re-)compilations. |
There was a problem hiding this comment.
Please change "AArch64 (ARM64)" to "AArch64(ARM64)".
There was a problem hiding this comment.
Please change "AArch64 (ARM64)" to "AArch64(ARM64)".
Okay!
|
changed |
README.md
Outdated
| (although it still needs recompilation of your program). Please see | ||
| [doc/uftrace-record.md](doc/uftrace-record.md) file. | ||
| Note that, there's an experimental support for dynamic tracing on | ||
| x86_64 and AArch64(ARM64) which doesn't require such (re-)compilations. |
There was a problem hiding this comment.
Please change it as follows:
| x86_64 and AArch64(ARM64) which doesn't require such (re-)compilations. | |
| x86_64 and AArch64(ARM64) which do not require such (re-)compilations. |
There was a problem hiding this comment.
Oh I forgot, I'll amend right away :)
| Also recent compilers have some options to help uftrace | ||
| to reduce tracing overhead with similar way | ||
| (although it still needs recompilation of your program). | ||
| Please see [doc/uftrace-record.md](doc/uftrace-record.md) file. |
There was a problem hiding this comment.
Please remove all the white spaces at the end of lines. They are shown as red blocks in the diff output.
|
removed white spaces at the end of lines! |
README.md
Outdated
| (although it still needs recompilation of your program). Please see | ||
| [doc/uftrace-record.md](doc/uftrace-record.md) file. | ||
| Note that, there's an experimental support for dynamic tracing on | ||
| x86_64 and AArch64(ARM64) which do not require such (re-)compilations. |
There was a problem hiding this comment.
I'm sorry for asking you again. I was wrong. "which doesn't require" is actually correct.
Everything looks good except for it. Thanks.
There was a problem hiding this comment.
I'm sorry for asking you again. I was wrong. "which doesn't require" is actually correct.
Everything looks good except for it. Thanks.
It's okay :) I'll fix it right away!
Since Lua 5.1 script is now available and dynamic tracing for AArch64 (ARM64) is possible in uftrace, this commit updates both English README and Korean README as containing those information.
|
Fixed |
Since Lua 5.1 script is now available and
dynamic tracing for AArch64 (ARM64) is possible in uftrace,
this commit updates both English README and Korean README
as containing those information.