Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add capstone package separately #833

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

honggyukim
Copy link
Collaborator

In some old distros such as Ubuntu 14.04, capstone is not provided.
In this case, the entire package installation gets failed.

  $ sudo ./misc/install-deps.sh
  Reading package lists... Done
  Building dependency tree
  Reading state information... Done
  E: Unable to locate package libcapstone-dev

To prevent such problems, it'd be better to add capstone installtion
separetely so that it doesn't affect other pacakge installation.

Signed-off-by: Honggyu Kim [email protected]

In some old distros such as Ubuntu 14.04, capstone is not provided.
In this case, the entire package installation gets failed.

  $ sudo ./misc/install-deps.sh
  Reading package lists... Done
  Building dependency tree
  Reading state information... Done
  E: Unable to locate package libcapstone-dev

To prevent such problems, it'd be better to add capstone installtion
separetely so that it doesn't affect other pacakge installation.

Signed-off-by: Honggyu Kim <[email protected]>
@namhyung
Copy link
Owner

It seems apt has -m/--ignore-missing but I couldn't find something similar for other package managers.

@namhyung
Copy link
Owner

But is Ubuntu 14.04 still used? I guess it's already in EOL (End-of-Life).

@honggyukim
Copy link
Collaborator Author

It seems apt has -m/--ignore-missing but I couldn't find something similar for other package managers.

If so, we can use the option.

But is Ubuntu 14.04 still used? I guess it's already in EOL (End-of-Life).

Yes, I was together with someone who use Ubuntu 14.04. It's not mandatory but better to consider some old environments if possible.

@honggyukim
Copy link
Collaborator Author

It seems apt has -m/--ignore-missing but I couldn't find something similar for other package managers.

I tested again with -m option, but it doesn't work as expected.

$ sudo apt-get install -m libdw-dev libcapstone-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package libcapstone-dev

It also fails to install libdw-dev as well so I think we better keep the current change.

@namhyung
Copy link
Owner

Hmm.. ok then

@honggyukim
Copy link
Collaborator Author

Is there any other issue on this?

@namhyung
Copy link
Owner

namhyung commented Aug 1, 2019

Nop, will merge.

Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhyung namhyung merged commit 4b4503c into namhyung:master Aug 1, 2019
@honggyukim honggyukim deleted the check/misc-capstone-install branch August 1, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants