-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Add Dockerfiles for arch, centos, ubuntu #887
Conversation
f9ed697
to
e276185
Compare
Hello, a just simple comment. uftrace has a dependency installation script.
|
@gy741 I didn't use install-deps.sh because this issue #883 is not fixed yet. |
You can use the script even if it's not ready yet since uftrace can be built without any dependent libraries. Once the archlinux support code is added, it'll automatically use them later. |
@namhyung Now I used misc/install-deps.sh in Dockerfiles. It looks like there is nothing more to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't want to have 2 commits for this. Could you please squash them into one? |
8a4e478
to
e1c1ea4
Compare
Using Dockerfiles, you can test uftrace on multiple distros easily. docker build -t <tagname> . This fixes namhyung#886 Signed-off-by: Byeonggon Lee <[email protected]>
I squashed just now |
Using Dockerfiles, you can test uftrace on multiple distros easily.
docker build -t .
This fixes #886
Signed-off-by: Byeonggon Lee [email protected]