Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add Dockerfiles for arch, centos, ubuntu #887

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

binkoni
Copy link
Contributor

@binkoni binkoni commented Sep 20, 2019

Using Dockerfiles, you can test uftrace on multiple distros easily.
docker build -t .
This fixes #886

Signed-off-by: Byeonggon Lee [email protected]

@binkoni binkoni force-pushed the docker branch 5 times, most recently from f9ed697 to e276185 Compare September 20, 2019 12:11
@gy741
Copy link
Contributor

gy741 commented Sep 20, 2019

Hello,

a just simple comment.

uftrace has a dependency installation script.

misc/install-deps.sh

https://github.com/namhyung/uftrace/blob/master/misc/install-deps.sh

@binkoni
Copy link
Contributor Author

binkoni commented Sep 20, 2019

@gy741 I didn't use install-deps.sh because this issue #883 is not fixed yet.
I could make pull request myself to that issue, but I'm waiting for @henrychoi7

@namhyung
Copy link
Owner

You can use the script even if it's not ready yet since uftrace can be built without any dependent libraries. Once the archlinux support code is added, it'll automatically use them later.

@binkoni
Copy link
Contributor Author

binkoni commented Sep 21, 2019

@namhyung Now I used misc/install-deps.sh in Dockerfiles. It looks like there is nothing more to do.

Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhyung
Copy link
Owner

I don't want to have 2 commits for this. Could you please squash them into one?

@binkoni binkoni force-pushed the docker branch 2 times, most recently from 8a4e478 to e1c1ea4 Compare September 23, 2019 01:34
Using Dockerfiles, you can test uftrace on multiple distros easily.
docker build -t <tagname> .
This fixes namhyung#886

Signed-off-by: Byeonggon Lee <[email protected]>
@binkoni
Copy link
Contributor Author

binkoni commented Sep 23, 2019

I squashed just now

@namhyung namhyung merged commit bb14dcc into namhyung:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docker images
4 participants