Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix typo error in uftrace-record.md #927

Merged
merged 1 commit into from
Oct 8, 2019
Merged

doc: Fix typo error in uftrace-record.md #927

merged 1 commit into from
Oct 8, 2019

Conversation

henrychoi7
Copy link
Contributor

@henrychoi7 henrychoi7 commented Oct 5, 2019 •
edited
Loading

I just found unnecessary ')' in line 550, DYNAMIC TRACING section.

Signed-off-by: Handong Choi [email protected]

@gy741
Copy link
Contributor

gy741 commented Oct 5, 2019 •
edited
Loading

Good catch!

Please add Signed-off-by: Handong Choi <[email protected]> in commit message

Ref:
https://github.com/namhyung/uftrace/blob/master/CONTRIBUTING.md

@henrychoi7
Copy link
Contributor Author

Oops, my bad. Fixed it right away! :)

namhyung
namhyung reviewed Oct 6, 2019
View reviewed changes
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message should have uftrace-record.md as PR.

@henrychoi7
doc: Fix typo error in uftrace-record.md
c0aacaf 
Unnecessary ')' in line 550.

Signed-off-by: Handong Choi <[email protected]>
@henrychoi7
Copy link
Contributor Author

henrychoi7 commented Oct 7, 2019 •
edited
Loading

@namhyung Fixed the commit message. Thanks again!

namhyung
namhyung approved these changes Oct 8, 2019
View reviewed changes
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhyung namhyung merged commit 4d06e6b into namhyung:master Oct 8, 2019
@henrychoi7 henrychoi7 deleted the patch-1 branch October 15, 2019 12:29
@henrychoi7 henrychoi7 mentioned this pull request Oct 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhyung namhyung namhyung approved these changes

Assignees
No one assigned
Labels
contributon2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrychoi7 @gy741 @namhyung @honggyukim