Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#56
β Type of change
π Description
Resolves #56
This adds an
enableHtmlInterpretation
setting which prevents the string body/icon from being interpreted as html. As mentioned in the issue, I've set it to default totrue
for now, but should be switched tofalse
along with the next breaking changes in the library.The main thing I was unsure of is the icon. I feel like in general, someone is far less likely to pass a user defined string into the icon field of the toasts than the body. Specifically, I have currently disabled the string form of the icon from being treated as html, but I didn't change the
Icon
object form of the icon. With the addition of JSX earlier, should the object form be deprecated?Feel free to adjust the name of the setting or the readme changes/jsdoc for it if needed.
π Checklist