Merge pull request #182 from nao1215/nao1215-patch-4

Add go 1.24
nao1215 · Feb 13, 2025 · 0832369 · 0832369
2 parents a938d8f + eac6855
commit 0832369
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml
@@ -19,6 +19,7 @@ jobs:
           - "macos-latest"
         go:
           - "1"
+          - "1.24"
           - "1.23"
           - "1.22"
           - "1.21"

diff --git a/cmd/root_test.go b/cmd/root_test.go
@@ -104,7 +104,7 @@ func TestExecute_Version(t *testing.T) {
 		{
 			name:   "success",
 			args:   []string{"gup", "version"},
-			stdout: []string{"gup version  (under Apache License version 2.0)", ""},
+			stdout: []string{"gup version (devel) (under Apache License version 2.0)", ""},
 		},
 	}
 	for _, tt := range tests {

diff --git a/internal/cmdinfo/cmdinfo.go b/internal/cmdinfo/cmdinfo.go
@@ -14,11 +14,13 @@ const Name = "gup"
 // GetVersion return gup command version.
 // Version global variable is set by ldflags.
 func GetVersion() string {
-	version := "unknown"
+	version := "(devel)"
 	if Version != "" {
 		version = Version
 	} else if buildInfo, ok := debug.ReadBuildInfo(); ok {
-		version = buildInfo.Main.Version
+		if buildInfo.Main.Version != "" {
+			version = buildInfo.Main.Version
+		}
 	}
 	return fmt.Sprintf("%s version %s (under Apache License version 2.0)", Name, version)
 }
diff --git a/internal/goutil/examples_test.go b/internal/goutil/examples_test.go
@@ -139,7 +139,7 @@ func ExampleGoBin() {
 	// Output: Example GoBin: OK
 }
 
-func ExampleInstall() {
+func ExampleInstallLatest() {
 	// Install installs an executable from a Go package.
 	err := goutil.InstallLatest("example.com/unknown_user/unknown_package")
 
@@ -160,7 +160,7 @@ func ExampleInstall() {
 	// Output: Example Install: OK
 }
 
-func ExampleIsAlreadyUpToDate() {
+func ExamplePackage_IsAlreadyUpToDate() {
 	// Create Version object with Current and Latest package and Go versions
 	ver := goutil.Version{
 		Current: "v1.9.0",
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ jobs: @@
               - "macos-latest"
             go:
               - "1"
+              - "1.24"
               - "1.23"
               - "1.22"
               - "1.21"
@@ Expand Down @@