Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call cancellation handler in each fingerpringmanager callback method #90

Closed
wants to merge 1 commit into from

Conversation

kmagiera
Copy link

Not calling cancellation signal in some cases leads to android to releasing the fingerprint manager properly, which on the other hand causes the fingerprint to fail immediately on a subsequent attempt. See this SO question for more details: https://stackoverflow.com/questions/45136354/fingerprint-operation-cancelled-while-using-in-app-authentication

Not calling cancellation signal in some cases leads to android to releasing the fingerprint manager properly, which on the other hand causes the fingerprint to fail immediately on a subsequent attempt. See this SO question for more details: https://stackoverflow.com/questions/45136354/fingerprint-operation-cancelled-while-using-in-app-authentication
@zibs
Copy link
Collaborator

zibs commented Feb 22, 2018

@kmagiera thanks! Will take a look and merge asap!

@rodan-lewarx
Copy link
Contributor

Does this solve the same issue as #81 ?

@zibs zibs mentioned this pull request Feb 26, 2018
@zibs
Copy link
Collaborator

zibs commented Feb 26, 2018

Thanks a lot for this suggestion @kmagiera. I've opened with #92 as a fix including this one and a fix for #81.

This branch actually died on me each time I used it, but I've implemented a very similar logic in my branch which works for me.

Take a look over there and see if that still works for you.

@zibs zibs closed this Feb 26, 2018
zibs added a commit that referenced this pull request Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants