Skip to content

Commit

Permalink
update encoding to text for ssh transport
Browse files Browse the repository at this point in the history
Tested on ssh transport on 4.28 EOS with ssh transport. 
When you run confirm_commit on ssh transport, napalm produces invalid syntax to commit the config without 'text' encoding.

LOGS:
DEBUG:netmiko:write_channel: b'configure session napalm_142144 commit | json\n'
DEBUG:netmiko:read_channel: 
DEBUG:netmiko:read_channel: configure session napalm_142144 commit | json
% Invalid input

This PR is to address this issue.
  • Loading branch information
carljungg authored and bewing committed Mar 5, 2025
1 parent 1ebd868 commit 2e40500
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion napalm/eos/eos.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def confirm_commit(self):
"configure session {} commit".format(self.config_session),
"write memory",
]
self._run_commands(commands)
self._run_commands(commands, encoding="text")
self.config_session = None
else:
raise CommitError("No pending commit-confirm found!")
Expand Down

0 comments on commit 2e40500

Please sign in to comment.