Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Fix for a race panic on macosx/darwin #5265

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

derekcollison
Copy link
Member

Was getting a panic of checkptr: converted pointer straddles multiple allocations in go 1.22.1 on darwin.

Signed-off-by: Derek Collison [email protected]

…raddles multiple allocations in go 1.22.1 on darwin.

Signed-off-by: Derek Collison <[email protected]>
@derekcollison derekcollison requested a review from a team as a code owner April 2, 2024 23:36
Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this worked locally for me. @neilalexander provided a fix for this as well, so I defer to him on this one.

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit f83276f into main Apr 3, 2024
4 checks passed
@derekcollison derekcollison deleted the sysmem-panic branch April 3, 2024 12:30
derekcollison added a commit that referenced this pull request Apr 4, 2024
Cherry-pick the following PRs into the v2.10.14 release branch:

* #5237
* #5238
* #5242
* #5208
* #5244
* #5248
* #5246
* #5112
* #5247
* #5256
* #5258
* #5264
* #5266
* #5267
* #5265
* #5271
* #5270
* #5272
* #5276
* #5274
* #5275
* #5277
* #5279

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants