[FIXED] LeafNode: connection may fail on slow link

[kozlovic]

Added the leafnode remote configuration parameter first_info_timeout
which is the amount of time that a server creating a leafnode
connection will wait for the initial INFO from the remote server.

Resolves #5417

Signed-off-by: Ivan Kozlovic [email protected]

[derekcollison]

If no one sets anything, how long can a leafnode exists before being declared stalled?

[kozlovic]

If no one sets anything, how long can a leafnode exists before being declared stalled?

pingInterval*time.Duration(pingMax+1), which since default ping interval is 2min, and max pings 2, it would be 2min*3=6min. Now for route and gateways, we cap the ping interval to 15 seconds I believe, so it is much smaller.

If you think this is too much, I could pass different values, but then it means adding a new configuration setting? (which was what the user wanted: make the wait configurable).

[derekcollison]

I think we want to make the wait configurable for leafnodes vs using the ping mechanism.

[kozlovic]

I think we want to make the wait configurable for leafnodes vs using the ping mechanism.

Ok, so a new value in a leaf node's remote configuration block and I assume that if not set, default to that constant that we were using.

[derekcollison]

Yes I believe so..

[kozlovic]

@derekcollison Sorry, did a force push with the amend because I wanted the commit log to be in phase with the use of a new config param instead of the original approach.

[derekcollison]

Just ping when ready for review.

[kozlovic]

It was/is ready for review. I was just saying that I did a push force (which I usually don't do once a code review has started).

[derekcollison]

LGTM