Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRG: When clfs=0, don't snapshot very often #6277

Merged
merged 1 commit into from
Dec 18, 2024
Merged

NRG: When clfs=0, don't snapshot very often #6277

merged 1 commit into from
Dec 18, 2024

Conversation

MauriceVanVeen
Copy link
Member

If the stream is ingesting loads of new messages, for example in a benchmark, either the compactNumMin or compactSizeMin would be reached fairly quickly. The minSnapDelta (10s) is used to not snapshot too often, since that would degrade performance.

However, if clfs=0 then we'd be forcing snapshots every time the compact minimums are reached.

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 18, 2024 08:55
derekcollison
derekcollison approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit dc8b344 into main Dec 18, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/snapshot-less branch December 18, 2024 14:07
@MauriceVanVeen MauriceVanVeen mentioned this pull request Dec 23, 2024
Merged
@wallyqs wallyqs mentioned this pull request Jan 8, 2025
Merged
wallyqs added a commit that referenced this pull request Jan 9, 2025
@wallyqs
Cherry-picks for 2.10.25-RC.1 (#6345)
339d1b3 
#### Dependencies
- #6323
- #6324

####  Leafnode
- #6291

#### JetStream
- #6226
- #6235
- #6277
- #6279
- #6283
- #6289
- #6316
- #6317
- #6325
- #6326
- #6335
- #6338
- #6341
- #6344
- #6150
- #6351
- #6355

#### Tests
- #6278
- #6297
- #6300
- #6343
- #6329
- #6330
- #6331
- #6332
- #6334
- #6356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @derekcollison