Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the comment that durable_name is deprecated #6412

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ripienaar
Copy link
Contributor

@ripienaar ripienaar commented Jan 27, 2025

We intended to deprecate this but did not do so in the end and it is critical in current API clients

Signed-off-by: R.I.Pienaar [email protected]

We intended to deprecate this but did not do so in the end
and it is critical in current API clients

Signed-off-by: R.I.Pienaar <[email protected]>
@ripienaar ripienaar requested a review from a team as a code owner January 27, 2025 13:37
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 654d051 into nats-io:main Jan 27, 2025
2 checks passed
@ripienaar ripienaar deleted the remove_durable_deprecation branch January 27, 2025 15:41
neilalexander added a commit that referenced this pull request Feb 6, 2025
Includes the following:

- #6406
- #6412
- #6408
- #6416
- #6425
- #6424
- #6438
- #6439
- #6446
- #6447
- #6448
- #6449
- #6450
- #6451
- #6452
- #6453
- #6456
- #6458
- #6457
- #6459
- #6460
- #6461

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants