[IMPROVED] Adjusted stalled producers to not be as penalizing. #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
force-pushed
the
stallgate
branch
from
a22d21f to
191754c
Compare
wallyqs
reviewed
Feb 21, 2025
|
From the perspective of someone not deeply familiar with NATS internals (which I imagine includes many customers), it would be helpful to include a sentence or two in the PR description explaining what is changing and why. |
|
@alexbozhenko linked to the kind of issues that this would fix: #5394 |
|
Fixed a broken test and updated warning based on @wallyqs feedback. |
|
We do have some actually, and we have lots of benchmarks that test it.. I could add more, but the msgtrace ones are pretty good. If we feel that is required, I can add it in.. |
neilalexander
approved these changes
Feb 24, 2025
|
I will see if I can write a test.. |
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
derekcollison
force-pushed
the
stallgate
branch
from
8ea76c8 to
0b125e8
Compare
|
I added a test, which caught a minor bug, so good idea. Should be ready for final review and I will squash once approved and tests are green. |
neilalexander
pushed a commit
that referenced
this pull request
Feb 24, 2025
Fixes #5394 Signed-off-by: Derek Collison <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Feb 25, 2025
Includes the following: - #6574 - #6568 - #6575 - #6576 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5394
Signed-off-by: Derek Collison [email protected]