Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Use faster gha runners and fix leaking goroutines in Service API #1794

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Feb 4, 2025

  • Switched to using ubuntu-latest-8-cores in CI as it seems to improve on the goleak flakes previously happening only in CI
  • Added missing goleak execution in Service API
  • Fixed leaking goroutine issues in Service API

Signed-off-by: Piotr Piotrowski [email protected]

Signed-off-by: Piotr Piotrowski <[email protected]>
@piotrpio piotrpio requested a review from Jarema February 4, 2025 11:43
@piotrpio piotrpio force-pushed the disable-goleak-in-ci branch from 036dcbb to 95edf5a Compare February 4, 2025 11:53
@piotrpio piotrpio marked this pull request as draft February 4, 2025 11:57
@piotrpio piotrpio force-pushed the disable-goleak-in-ci branch 2 times, most recently from 7425524 to 59fedf4 Compare February 4, 2025 12:01
@piotrpio piotrpio changed the title [IMPROVED] Disable goleak in CI and fix leaking goroutines in Service API [IMPROVED] Use faster gha runners and fix leaking goroutines in Service API Feb 4, 2025
@piotrpio piotrpio force-pushed the disable-goleak-in-ci branch from 59fedf4 to 39e42dc Compare February 4, 2025 14:24
@piotrpio piotrpio marked this pull request as ready for review February 4, 2025 15:06
@piotrpio piotrpio requested a review from aricart February 4, 2025 15:08
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit b1be9bf into main Feb 4, 2025
6 checks passed
@piotrpio piotrpio deleted the disable-goleak-in-ci branch February 4, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants