Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borsh_skip to borsh(skip) #192

Merged
merged 5 commits into from
Aug 16, 2023
Merged

borsh_skip to borsh(skip) #192

merged 5 commits into from
Aug 16, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Aug 14, 2023

It is part of Prepare for stability (1.0 release) #51 initiative

iho added 3 commits August 15, 2023 12:29
 git apply skip.diff
 remove pub(crate) fn contains_skip(attrs: &[Attribute]) -> bool completely
 change signature of Attributes::parse: pub(crate) fn parse(attrs: &[Attribute], skipped: bool) -> Result<Self, syn::Error> => pub(crate) fn parse(attrs: &[Attribute]) -> Result<Self, syn::Error>
@dj8yfo dj8yfo marked this pull request as ready for review August 16, 2023 19:05
@dj8yfo dj8yfo requested a review from frol as a code owner August 16, 2023 19:05
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! It seems to be the last breaking change before 1.0.0 release

@iho Thanks for working on this! 🎉

@frol frol merged commit b8be388 into near:master Aug 16, 2023
@frol frol mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants