Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: forbid multiple borsh attr occurencies #199

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 17, 2023

Context:

We either needed to implement attributes merging or forbid multiple attribute occurences. We decided that the latter is easier to implement, and it won't be a breaking change to relax this requirement in the future, if needed.

@dj8yfo dj8yfo marked this pull request as ready for review August 17, 2023 14:58
@dj8yfo dj8yfo requested a review from frol as a code owner August 17, 2023 14:58
@dj8yfo dj8yfo force-pushed the forbid_multiple_attrs branch from daabcb5 to 3f5d964 Compare August 24, 2023 18:57
@frol frol changed the title feat: forbid multiple borsh attr occurencies feat!: forbid multiple borsh attr occurencies Aug 28, 2023
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it offline, and decided that we want to see if we can get away with this constraint for now. If it will be identified in the future that it is too limiting, it would not be a breaking change to allow multiple #[borsh] tags.

@dj8yfo dj8yfo merged commit 2cdd8f8 into master Aug 29, 2023
@dj8yfo dj8yfo deleted the forbid_multiple_attrs branch August 29, 2023 11:56
@frol frol mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants